[llvm-commits] [compiler-rt] r151157 - /compiler-rt/trunk/lib/asan/Makefile.old

Kostya Serebryany kcc at google.com
Wed Feb 22 09:57:32 PST 2012


You solved wrong problem with this change.

Instead, we need to build gtest w/o asan (and allow linking a pre-built
system gtest).
It did not work last time I tried (gtest uses static CTORs which call some
functions we intercept).
But we need to fix this.

--kcc


On Wed, Feb 22, 2012 at 9:34 AM, Alexey Samsonov <samsonov at google.com>wrote:

> Looks like our linux bot was red today because of this.
> Gtest needs libasan.a in clang lib dir, but w/o this dependency
> makefile could start building gtest before libasan and failed.
>
> Why?
>> This will cause gtest to be rebuilt on every change?
>>
>> On Wed, Feb 22, 2012 at 3:59 AM, Alexey Samsonov <samsonov at google.com>wrote:
>>
>>> Author: samsonov
>>> Date: Wed Feb 22 05:59:44 2012
>>> New Revision: 151157
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=151157&view=rev
>>> Log:
>>> AddressSanitizer: fix Makefile.old - gtest should depend on libasan
>>>
>>> Modified:
>>>    compiler-rt/trunk/lib/asan/Makefile.old
>>>
>>> Modified: compiler-rt/trunk/lib/asan/Makefile.old
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/Makefile.old?rev=151157&r1=151156&r2=151157&view=diff
>>>
>>> ==============================================================================
>>> --- compiler-rt/trunk/lib/asan/Makefile.old (original)
>>> +++ compiler-rt/trunk/lib/asan/Makefile.old Wed Feb 22 05:59:44 2012
>>> @@ -320,7 +320,7 @@
>>>  asan_benchmarks: $(BIN)/asan_benchmarks$(SUFF)
>>>
>>>  # for now, build gtest with clang/asan even if we use a different
>>> compiler.
>>> -$(GTEST_LIB):
>>> +$(GTEST_LIB): $(LIBASAN_A)
>>>        mkdir -p $(GTEST_MAKE_DIR) && \
>>>        cd $(GTEST_MAKE_DIR) && \
>>>        $(MAKE) -f ../make/Makefile CXXFLAGS="$(PIE) $(CFLAGS) -g -w" \
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>>
>>
>>
>
>
> --
> Alexey Samsonov
> Software Engineer, Moscow
> samsonov at google.com
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120222/818624ef/attachment.html>


More information about the llvm-commits mailing list