[llvm-commits] [ASan] Intercept functions on Windows - first version (issue 5690065)

samsonov at google.com samsonov at google.com
Wed Feb 22 05:16:05 PST 2012


On 2012/02/22 13:04:16, timurrrr_at_google_com wrote:
> Hi Alexander, Evgeniy,

> Can you please review this patch?
> It adds some basic support for function interception on Windows.

IMO InitializeAllInterceptors() really does look horrible now :)
I think we need to use functions like:
InitializeSignalInterceptors()
InitializePthreadInterceptors()
InitializeGCDInterceptors()
and so on. Probably these functions can be defined in their own .cc
file, but even now they may simplify things.

Also, what about using if (ASAN_WINDOWS)?

> Thanks,
> Timur



http://codereview.appspot.com/5690065/



More information about the llvm-commits mailing list