[llvm-commits] Bug in "call __chkstak" on 64 bit OS

Yatsina, Marina marina.yatsina at intel.com
Tue Feb 21 10:05:54 PST 2012


Hi,

I've fixed the patch according to the feedback, honoring the code model.

-----Original Message-----
From: Anton Korobeynikov [mailto:anton at korobeynikov.info] 
Sent: Monday, February 20, 2012 16:46
To: Rotem, Nadav
Cc: NAKAMURA Takumi; llvm-commits at cs.uiuc.edu; Yatsina, Marina
Subject: Re: [llvm-commits] Bug in "call __chkstak" on 64 bit OS

Nadav,

>  So, the problem with the proposed patch is that it does not honor the code model and that it issues an indirect jump on win64 when a 'small' code model is used, right ?
Almost correct. call to chkstk should behave the same way as all other
calls. So, it will be pcrel32 in small, kernel and medium code models.
And indirect in large.

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Win64CallCheckStackLLVMTrunk.patch
Type: application/octet-stream
Size: 8351 bytes
Desc: Win64CallCheckStackLLVMTrunk.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120221/6ba9d8a5/attachment.obj>


More information about the llvm-commits mailing list