[llvm-commits] Patch for pr11798: Emit _fltused during FastISel

Joe Groff arcata at gmail.com
Tue Feb 21 01:54:48 PST 2012

On Mon, Feb 20, 2012 at 11:39 PM, Anton Korobeynikov
<anton at korobeynikov.info> wrote:

> I don't think that this routine should be in the common code...
> However, I do not see the proper place right now. Maybe Eli knows :)

No problem. I can move it to FunctionInfo instead as Eli originally recommended.

> 1. Use the same code style as all other routines in the file.

What needs to change exactly? I thought I was just moving existing code around.

> 5. +      for (po_iterator<Type*> i = po_begin(T), e = po_end(T);
> Should we traverse the whole Type tree here? Should fltused be emitted
> even if we e.g. passing point to struct contaning float?

I believe the important case is printf("%f"), so going one layer deep
should be sufficient. However, I'm not enough of a Windows expert to
know if it's technically necessary in deeper case.

> Also... is is possible somehow shorten
> "setCallsExternalVAFunctionWithFloatingPointArguments".... ?

Sure, I'll do that.

Thanks for the feedback, Anton.


More information about the llvm-commits mailing list