[llvm-commits] AddressSanitizer: Don't include GrandCentralDispatch headers in asan headers on Mac (issue 5689057)

samsonov at google.com samsonov at google.com
Tue Feb 21 00:36:46 PST 2012


r151044


http://codereview.appspot.com/5689057/diff/1/asan_mac.h
File asan_mac.h (right):

http://codereview.appspot.com/5689057/diff/1/asan_mac.h#newcode38
asan_mac.h:38: typedef void* dispatch_group_t;
On 2012/02/21 08:34:55, glider wrote:
> On 2012/02/21 08:24:11, eugeni.stepanov wrote:
> > Not a big deal, but I would just use void* in the function
signatures.

> Please no. We'll end up having (void*, void*, void*) function
prototypes and
> soon won't be able to tell which original types were there.

Yeah, I left typedefs to make function decl look similar to the
original.

http://codereview.appspot.com/5689057/



More information about the llvm-commits mailing list