[llvm-commits] PATCH: Remove lazy-parse support from llvm::Triple

Chandler Carruth chandlerc at gmail.com
Mon Feb 20 11:49:07 PST 2012


Hello LLVM folks (and Clang folks sense triple impacts the Clang driver
greatly)!

This patch removes the lazy-parsing from the Triple class. From what I
could tell, no one deeply relied on this, and it seems unlikely that we
want people to be creating enough triples to need them to parse lazily...

The code gets significantly simpler with this change, and I'm looking at
further changes that will make it more efficient and still cleaner.

In passing, it fixes a bug in 'hasEnvironment' which would return the wrong
answer if called before any other accessors on a triple. This category of
bugs is one of the primary reasons I'm not a fan of deferred parsing here.

All existing tests seem happy, and I can add a few more, as well as look
for any cleanups I missed, but I wanted to get some feedback on the general
direction.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120220/2bdc32ae/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove-lazy-parse.patch
Type: text/x-patch
Size: 9076 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120220/2bdc32ae/attachment.bin>


More information about the llvm-commits mailing list