[llvm-commits] [PATCH] LIT cleanup phase #1 - replacing dg.exp with lit.local.cfg

[Bendersky, Eli]

Thanks for the review
Committed in r150664

> -----Original Message-----
> From: daniel.dunbar at gmail.com [mailto:daniel.dunbar at gmail.com] On
> Behalf Of Daniel Dunbar
> Sent: Wednesday, February 15, 2012 17:28
> To: Bendersky, Eli
> Cc: llvm-commits at cs.uiuc.edu
> Subject: Re: [PATCH] LIT cleanup phase #1 - replacing dg.exp with lit.local.cfg
> 
> Hey Eli,
> 
> Patch looks great, thanks for working on this!
> 
> As you noted the duplication of getRoot() is lame, but seems fine for now
> since you plan to clean it up later.
> 
>  - Daniel
> 
> On Wed, Feb 8, 2012 at 4:42 AM, Bendersky, Eli <eli.bendersky at intel.com>
> wrote:
> > Hello,
> >
> > I've started working on cleaning up LIT a bit. The overall cleanup plan was
> approved by Daniel Dunbar. The first patch (attached) is ready for review.
> >
> > The LIT global configuration currently relies on "dg.exp" files to find out
> which file extensions have tests, and which targets are supported for these
> tests. This is a relic from old times and is no longer required for LIT runs. LIT
> already has good infrastructure for specifying these things via lit.local.cfg - in
> fact it's already being used in Clang tests instead of dg.exp.
> >
> > The attached patch translates all existing dg.exp files into respective
> lit.local.cfg files. Also, the configuration-specific information was moved from
> site.exp to lit.site.cfg, as appropriate.
> >
> > To keep the first patch minimal (it's rather large even now, because a lot of
> files were modified), some things are left for next patches:
> >
> > * I've made lit.cfg just ignore the fact that it can't find dg.exp, meaning that
> dg.exp is in theory still supported. This code in lit.cfg will be cleaned up, as
> well as removing the generation, reading and parsing of site.exp - which is
> also no longer needed.
> > * There's a bit of duplication in some of the lit.local.cfg files for reaching the
> root configuration. This duplication is "borrowed" from the Clang lit.local.cfg
> files, where it also exists. In a future patch I plan to clean it up (including the
> Clang lit files), probably by adding a new configuration attribute exposed
> from the LIT library itself that will allow local configs to easily access the root.
> >
> > Eli
> >
> >
> >
> > ---------------------------------------------------------------------
> > Intel Israel (74) Limited
> >
> > This e-mail and any attachments may contain confidential material for
> > the sole use of the intended recipient(s). Any review or distribution
> > by others is strictly prohibited. If you are not the intended
> > recipient, please contact the sender and delete all copies.
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.