[llvm-commits] [dragonegg] r150341 - in /dragonegg/trunk: include/dragonegg/ABI.h src/DefaultABI.cpp

[Bill Wendling]

On Feb 12, 2012, at 7:35 AM, Duncan Sands wrote:

> Author: baldrick
> Date: Sun Feb 12 09:35:35 2012
> New Revision: 150341
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=150341&view=rev
> Log:
> Add anchor for vtable.
> 
> Modified:
>    dragonegg/trunk/include/dragonegg/ABI.h
>    dragonegg/trunk/src/DefaultABI.cpp
> 
> Modified: dragonegg/trunk/include/dragonegg/ABI.h
> URL: http://llvm.org/viewvc/llvm-project/dragonegg/trunk/include/dragonegg/ABI.h?rev=150341&r1=150340&r2=150341&view=diff
> ==============================================================================
> --- dragonegg/trunk/include/dragonegg/ABI.h (original)
> +++ dragonegg/trunk/include/dragonegg/ABI.h Sun Feb 12 09:35:35 2012
> @@ -42,6 +42,7 @@
> /// DefaultABIClient - This is a simple implementation of the ABI client
> /// interface that can be subclassed.
> struct DefaultABIClient {
> +  virtual void anchor();
>   virtual ~DefaultABIClient() {}

Why not just use the d'tor as the anchor instead of a whole other (unused) method?

-bw

>   virtual CallingConv::ID getCallingConv(void) = 0;
>   virtual bool isShadowReturn() const { return false; }
> 
> Modified: dragonegg/trunk/src/DefaultABI.cpp
> URL: http://llvm.org/viewvc/llvm-project/dragonegg/trunk/src/DefaultABI.cpp?rev=150341&r1=150340&r2=150341&view=diff
> ==============================================================================
> --- dragonegg/trunk/src/DefaultABI.cpp (original)
> +++ dragonegg/trunk/src/DefaultABI.cpp Sun Feb 12 09:35:35 2012
> @@ -37,6 +37,8 @@
> #include "tree.h"
> }
> 
> +void DefaultABIClient::anchor() {}
> +
> // doNotUseShadowReturn - Return true if the specified GCC type
> // should not be returned using a pointer to struct parameter.
> bool doNotUseShadowReturn(tree type, tree fndecl, CallingConv::ID CC) {
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits