[llvm-commits] [ASan] The first version of the RTL for Windows (issue 5647052)

[timurrrr at google.com]

PTAL


http://codereview.appspot.com/5647052/diff/6001/lib/asan/asan_allocator.cc
File lib/asan/asan_allocator.cc (right):

http://codereview.appspot.com/5647052/diff/6001/lib/asan/asan_allocator.cc#newcode692
lib/asan/asan_allocator.cc:692: #if defined(_WIN32)
On 2012/02/08 18:03:10, kcc wrote:
> instead of the ifdef clatter, I'd prefer to have
> if (WINDOWS)

Done.

http://codereview.appspot.com/5647052/diff/6001/lib/asan/asan_interceptors.cc
File lib/asan/asan_interceptors.cc (right):

http://codereview.appspot.com/5647052/diff/6001/lib/asan/asan_interceptors.cc#newcode626
lib/asan/asan_interceptors.cc:626: #ifdef _WIN32
On 2012/02/08 18:03:10, kcc wrote:
> if (WINDOWS) please
> or "if (ASAN_WINDOWS)"
You can't do that - it won't compile on Linux (where we don't include
the headers defining memcpy/memset )
Here "#ifdef _WIN32" is doing what it should -> compile some code only
on Windows

> also, feel free to change the code below to if (ASAN_APPLE)
Leaving this up to Alexander, as this might also not compile on
non-Apple

http://codereview.appspot.com/5647052/diff/10/lib/asan/asan_internal.h
File lib/asan/asan_internal.h (right):

http://codereview.appspot.com/5647052/diff/10/lib/asan/asan_internal.h#newcode63
lib/asan/asan_internal.h:63: # define ASAN_LINUX   1
Defined the ASAN_* macros.

I don't like the N^2 number of definitions though

http://codereview.appspot.com/5647052/