[llvm-commits] Implement the GET_CALLER_PC macro, stub the GET_CURRENT_FRAME macro (issue 5630065)

[Timur Iskhodzhanov]

PTAL,
though personally I don't like how it looks now.

On Tue, Feb 7, 2012 at 9:36 PM, Kostya Serebryany <kcc at google.com> wrote:
>
>
> On Tue, Feb 7, 2012 at 4:51 AM, <timurrrr at google.com> wrote:
>>
>>
>> http://codereview.appspot.com/5630065/diff/1/lib/asan/asan_internal.h
>> File lib/asan/asan_internal.h (right):
>>
>>
>> http://codereview.appspot.com/5630065/diff/1/lib/asan/asan_internal.h#newcode24
>> lib/asan/asan_internal.h:24: # include <intrin.h>
>> On 2012/02/06 19:18:31, kcc wrote:
>>>
>>> Can we avoid this include in the header?
>>> ( I am not sure we can, just asking)
>>
>> I doubt so.
>> Or we'll need to #include it in every file which uses GET_CURRENT_PC or
>> GET_BP_PC_SP.
>
>
> Maybe you can find how this thing is defined in intrin.h and use similar
> definition?
>
>
> --kcc