[llvm-commits] [PATCH 01/13] Add For Loop Structures

[Jakob Stoklund Olesen]

On Feb 7, 2012, at 8:13 AM, greened at obbligato.org (David A. Greene) wrote:

> 
> Jakob Stoklund Olesen <stoklund at 2pi.dk> writes:
>> I think it is explained quite well here:
>> 
>> http://llvm.org/docs/DeveloperPolicy.html#newwork
>> http://llvm.org/docs/DeveloperPolicy.html#incremental
> 
> I tried to follow this guide.  For example, making the "setup" changes
> before turning the feature on.

Of course the granularity is a judgment call, but in general, don't submit multiple patches at once. The exception is large mechanical changes like changing constness or namespaces etc.

The roundtrip delay on pre-commit reviews makes it necessary to review larger changes than one would normally commit directly. In the present case, I think the granularity you chose is fine: 1. Add a single-variable foreach loop. 2. Zip.

If you need to make changes that reach into other parts of the code, they should be submitted and reviewed independently. Always make sure reviewers know why you need to make the change.

/jakob