[llvm-commits] Implement the GET_CALLER_PC macro, stub the GET_CURRENT_FRAME macro (issue 5630065)

konstantin.s.serebryany at gmail.com konstantin.s.serebryany at gmail.com
Mon Feb 6 11:18:31 PST 2012


http://codereview.appspot.com/5630065/diff/1/lib/asan/asan_internal.h
File lib/asan/asan_internal.h (right):

http://codereview.appspot.com/5630065/diff/1/lib/asan/asan_internal.h#newcode24
lib/asan/asan_internal.h:24: # include <intrin.h>
Can we avoid this include in the header?
( I am not sure we can, just asking)

http://codereview.appspot.com/5630065/diff/1/lib/asan/asan_internal.h#newcode218
lib/asan/asan_internal.h:218:
(uintptr_t)__builtin_extract_return_address(__builtin_return_address(0))
I'd keep this as as, it works.

http://codereview.appspot.com/5630065/diff/1/lib/asan/asan_internal.h#newcode222
lib/asan/asan_internal.h:222: // TODO(timurrrr): We don't unwind on
Windows - do we need this?
What do you mean "we don't unwind"?
Also, better use FIXME instead of TODO(user)

http://codereview.appspot.com/5630065/



More information about the llvm-commits mailing list