[llvm-commits] Fixed a bug in VCMPPS (X86 AVX) pseudo instructions - Please review

[Demikhovsky, Elena]

According to AVX spec only 5 bits are taken, other just ignored. But you do not expect that clang or another user writes a bigger number. It sounds like a bug in compiler or user code. And the better way is indicating that value is unexpected then just truncating it.

- Elena

-----Original Message-----
From: Eric Christopher [mailto:echristo at apple.com] 
Sent: Monday, February 06, 2012 08:54
To: Craig Topper
Cc: Demikhovsky, Elena; llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] Fixed a bug in VCMPPS (X86 AVX) pseudo instructions - Please review


On Feb 5, 2012, at 9:24 PM, Craig Topper wrote:

> As nothing protects the value written in the intrinsic in the source code. I don't think that having a default case for all unexpected values is the right way to go. Maybe the immediate should be masked to remove the reserved encodings? Or the full value should be printed as an integer if its too big?


Sounds good to me.

-eric
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.