[llvm-commits] [PATCH] add LLVM_{MAJOR,MINOR}_VERSION defines

Duncan Sands baldrick at free.fr
Sun Feb 5 05:11:37 PST 2012


Hi nobled, LGTM.  However I'm not a build system wizard, so probably someone
who is should concur before you apply it.

Ciao, Duncan.

On 05/02/12 07:06, nobled wrote:
> On Sat, Feb 4, 2012 at 3:53 AM, Duncan Sands<baldrick at free.fr>  wrote:
>> Hi nobled,
>>
>>> This is useful for clients that want to maintain compatibility
>>> across multiple releases of LLVM. Currently users like Klee and
>>> Mesa all have to roll their own 'parse llvm-config --version
>>> output and generate defines' solution.
>>
>> +set(LLVM_VERSION_MAJOR 3)
>> +set(LLVM_VERSION_MINOR 1)
>> +
>>   set(PACKAGE_VERSION "3.1svn")
>>
>> Shouldn't the package version make use of LLVM_VERSION_MAJOR and
>> LLVM_VERSION_MINOR?
> Oops, yeah, definitely. Fixed.
>
>>
>> Ciao, Duncan.
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits




More information about the llvm-commits mailing list