[llvm-commits] [llvm] r149765 - /llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp

[Nick Lewycky]

Author: nicholas
Date: Fri Feb  3 23:26:17 2012
New Revision: 149765

URL: http://llvm.org/viewvc/llvm-project?rev=149765&view=rev
Log:
Fix a leak!

Andy, in a previous commit you made this into an ImmutablePass so that you could
add it to the PassManager, then in the next commit you left it a Pass but
removed the code that added it to the PM. If you do add it to the PM then the PM
should take care of deleting it, but it's also true that nothing in codegen
needs this object to exist after it's done its work here. It's not clear to me
which design you want; this should likely either cease to be a Pass or be added
to the PM where other parts of CodeGen will request it.

Modified:
    llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp

Modified: llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp?rev=149765&r1=149764&r2=149765&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp (original)
+++ llvm/trunk/lib/CodeGen/LLVMTargetMachine.cpp Fri Feb  3 23:26:17 2012
@@ -145,6 +145,8 @@
 
   PassConfig->addMachinePasses();
 
+  delete PassConfig;
+
   return Context;
 }