[llvm-commits] [llvm] r149654 - in /llvm/trunk: include/llvm/Transforms/Utils/SSAUpdaterImpl.h test/Transforms/ScalarRepl/phi-cycle.ll

[Nick Lewycky]

On 3 February 2012 10:02, Chad Rosier <mcrosier at apple.com> wrote:

>
> On Feb 3, 2012, at 12:45 AM, Duncan Sands <baldrick at free.fr> wrote:
>
> > On 03/02/12 03:02, Chad Rosier wrote:
> >>
> >> On Feb 2, 2012, at 5:57 PM, Nick Lewycky <nlewycky at google.com
> >> <mailto:nlewycky at google.com>> wrote:
> >>
> >>> On 2 February 2012 17:07, Dan Gohman <gohman at apple.com
> >>> <mailto:gohman at apple.com>> wrote:
> >>>
> >>>    Author: djg
> >>>    Date: Thu Feb 2 19:07:01 2012
> >>>    New Revision: 149654
> >>>
> >>>    URL: http://llvm.org/viewvc/llvm-project?rev=149654&view=rev
> >>>    <http://llvm.org/viewvc/llvm-project?rev=149654&view=rev>
> >>>    Log:
> >>>    Fix SSAUpdaterImpl's RecordMatchingPHI to record exactly the
> >>>    PHI nodes which were matched, rather than climbing up the
> >>>    original PHI node's operands to rediscover PHI nodes for
> >>>    recording, since the PHI nodes found that are not
> >>>    necessarily part of the matched set.
> >>>    This fixes rdar://10589171.
> >>>
> >>>
> >>> You mean PR11535?
> >>
> >> Yes, Eli cloned PR11535 to rdar://10589171; the two are synonymous.
> >
> > Except that a rdar reference is useless to people outside of Apple.
> >
>
> We do our best to references PRs.  Eli did commented in the PR that it had
> been cloned to rdar://10589171.
>

Sorry, I didn't mean to suggest any annoyance. I meant for it to serve as a
reminder to close the PR if it's fixed, or else explain what else in the PR
is left that wasn't part of this commit (it isn't clear to me that the rdar
is synonymous with the PR vesus being one particular issue from the
testcase, etc.). I do appreciate the effort to go back to PR numbers, I
have to do the same thing myself when going out of our internal bugtracker.

Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120203/9bd1a8ab/attachment.html>