[llvm-commits] [llvm] r149548 - in /llvm/trunk: lib/Target/X86/X86ISelLowering.cpp test/CodeGen/X86/shl-i64.ll

[Rotem, Nadav]

A few weeks ago when I worked on a DAGCombine optimization I ran into the following problem. I accidently created a vector shift with a scalar shift amount. I wanted to address the problem by adding an assertion in DAG.getNode that checks that the shift amount is vector iff the first operand is a vector; However, I noticed that the cell backend has patterns that match scalar shift count for vectors. 

-----Original Message-----
From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-bounces at cs.uiuc.edu] On Behalf Of Duncan Sands
Sent: Friday, February 03, 2012 10:44
To: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [llvm] r149548 - in /llvm/trunk: lib/Target/X86/X86ISelLowering.cpp test/CodeGen/X86/shl-i64.ll

Hi, it looks like the shift amount has illegal type.  Probably you should open a bug report about this.

Ciao, Duncan.

> No, I don't see why this would behave differently on ppc vs x86.  We are prevent generate an illegal i64 extract element.
>
>    -- Mon Ping
>
> On Feb 2, 2012, at 3:53 AM, NAKAMURA Takumi wrote:
>
>> 2012/2/2 Mon P Wang<wangmp at apple.com>:
>>> Author: wangmp
>>> Date: Wed Feb  1 16:15:20 2012
>>> New Revision: 149548
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=149548&view=rev
>>> Log:
>>> Avoid creating an extract element to an illegal type after LegalizeTypes has run.
>>>
>>> Added:
>>>     llvm/trunk/test/CodeGen/X86/shl-i64.ll
>>> Modified:
>>>     llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
>>
>> It crashes on ppc32-linux. Any idea?
>> http://bb.pgr.jp/builders/clang-ppc-linux/builds/1150
>>
>> ...Takumi
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.