[llvm-commits] [LLVMdev] Best way to interface with MSVC _ftol2 runtime function for fptoui?

Jakob Stoklund Olesen stoklund at 2pi.dk
Thu Feb 2 16:15:34 PST 2012


On 2012 1 24, at 22:56, Joe Groff <arcata at gmail.com> wrote:

> Here is a patch that integrates the WIN_FTOL pseudo-insn a bit better
> with the floating-point register allocator by following a simplified
> version of what InlineAsm does, as you suggested. Does this look
> closer to being right? Thanks again for all your help.

That looks better, but you need to put more work into the tests. You are not testing the stack shuffling and the kill/no kill difference.

Also, please don't send patches to llvm-dev. Even if you don't think they are ready for review, llvm-dev has twice the audience.

/jakob




More information about the llvm-commits mailing list