[llvm-commits] [llvm] r149598 - /llvm/trunk/lib/CodeGen/RegisterCoalescer.cpp

[Jakob Stoklund Olesen]

On Feb 2, 2012, at 12:01 AM, Lang Hames wrote:

> Author: lhames
> Date: Thu Feb  2 02:01:53 2012
> New Revision: 149598
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=149598&view=rev
> Log:
> Re-apply the coalescer fix from r149147. Commit r149597 should have fixed the llvm-gcc and clang self-host issues.
> 
> Modified:
>    llvm/trunk/lib/CodeGen/RegisterCoalescer.cpp

Hi Lang,

Ideally, this code would live in LiveRangeEdit, and the coalescer would use LRE to perform the remat. That way, you can also integrate instant dead code elimination:

  LRE.remat(...);
  LIS->shrinkToUses(SrcInt, DeadDefs);
  LRE.eliminateDeadDefs(DeadDefs);

This would allow us to get rid of the somewhat incomplete late dead code elimination in RegisterCoalescer.

/jakob