[llvm-commits] FW: [PATCH] enabling generation of ELF objects on Windows with the help of the triple

[Bendersky, Eli]

> > Let me see if I grok your proposal. You want the "container override" to be
> implemented in a way that is generic and not only active for ELF. Is that right?
> In this case, I think we're already almost there. If you look at the usage of
> Triple.getEnvironment(), you'll notice that the "MachO override" was already
> implemented.
> Well... parts at least in lib/Target/X86/X86Subtarget.h and
> lib/Target/X86/MCTargetDesc/X86AsmBackend.cpp look really weird,
> because they make ELF as a special case. Look for MachO usage nearby.
> 
> In particular, I think that all stuff like getEnvironment() != ELF should be
> removed / refactored.
> 

Anton, I think I see what you mean. The parallel thread with Eric discusses larger, conceptual differences which may end in all this code being changed to something completely different. However, if this approach is eventually accepted, I will try to streamline the special-casing for ELF to be more logical and similar to the special-casing for MachO, as you say.

Thanks for your input,
Eli

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.