[llvm-commits] [llvm] r149472 - in /llvm/trunk: include/llvm-c/Transforms/Vectorize.h lib/Transforms/Vectorize/BBVectorize.cpp

[Hal Finkel]

Author: hfinkel
Date: Tue Jan 31 23:51:45 2012
New Revision: 149472

URL: http://llvm.org/viewvc/llvm-project?rev=149472&view=rev
Log:
A few of the changes suggested in code review (by Nick Lewycky)

Modified:
    llvm/trunk/include/llvm-c/Transforms/Vectorize.h
    llvm/trunk/lib/Transforms/Vectorize/BBVectorize.cpp

Modified: llvm/trunk/include/llvm-c/Transforms/Vectorize.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm-c/Transforms/Vectorize.h?rev=149472&r1=149471&r2=149472&view=diff
==============================================================================
--- llvm/trunk/include/llvm-c/Transforms/Vectorize.h (original)
+++ llvm/trunk/include/llvm-c/Transforms/Vectorize.h Tue Jan 31 23:51:45 2012
@@ -1,4 +1,4 @@
-/*===---------------------------Vectorize.h ------------------- -*- C++ -*-===*\
+/*===---------------------------Vectorize.h --------------------- -*- C -*-===*\
 |*===----------- Vectorization Transformation Library C Interface ---------===*|
 |*                                                                            *|
 |*                     The LLVM Compiler Infrastructure                       *|

Modified: llvm/trunk/lib/Transforms/Vectorize/BBVectorize.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Vectorize/BBVectorize.cpp?rev=149472&r1=149471&r2=149472&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Vectorize/BBVectorize.cpp (original)
+++ llvm/trunk/lib/Transforms/Vectorize/BBVectorize.cpp Tue Jan 31 23:51:45 2012
@@ -300,6 +300,7 @@
       AU.addRequired<ScalarEvolution>();
       AU.addPreserved<AliasAnalysis>();
       AU.addPreserved<ScalarEvolution>();
+      AU.setPreservesCFG();
     }
 
     // This returns the vector type that holds a pair of the provided type.
@@ -308,9 +309,9 @@
       if (VectorType *VTy = dyn_cast<VectorType>(ElemTy)) {
         unsigned numElem = VTy->getNumElements();
         return VectorType::get(ElemTy->getScalarType(), numElem*2);
-      } else {
-        return VectorType::get(ElemTy, 2);
       }
+
+      return VectorType::get(ElemTy, 2);
     }
 
     // Returns the weight associated with the provided value. A chain of
@@ -431,7 +432,7 @@
     std::vector<Value *> PairableInsts;
     std::multimap<Value *, Value *> CandidatePairs;
     getCandidatePairs(BB, CandidatePairs, PairableInsts);
-    if (PairableInsts.size() == 0) return false;
+    if (PairableInsts.empty()) return false;
 
     // Now we have a map of all of the pairable instructions and we need to
     // select the best possible pairing. A good pairing is one such that the
@@ -444,7 +445,7 @@
 
     std::multimap<ValuePair, ValuePair> ConnectedPairs;
     computeConnectedPairs(CandidatePairs, PairableInsts, ConnectedPairs);
-    if (ConnectedPairs.size() == 0) return false;
+    if (ConnectedPairs.empty()) return false;
 
     // Build the pairable-instruction dependency map
     DenseSet<ValuePair> PairableInstUsers;
@@ -459,7 +460,7 @@
     choosePairs(CandidatePairs, PairableInsts, ConnectedPairs,
       PairableInstUsers, ChosenPairs);
 
-    if (ChosenPairs.size() == 0) return false;
+    if (ChosenPairs.empty()) return false;
     NumFusedOps += ChosenPairs.size();
 
     // A set of pairs has now been selected. It is now necessary to replace the
@@ -647,8 +648,8 @@
       UsesI = true;
 
     if (!UsesI)
-      for (User::op_iterator JU = J->op_begin(), e = J->op_end();
-           JU != e; ++JU) {
+      for (User::op_iterator JU = J->op_begin(), JE = J->op_end();
+           JU != JE; ++JU) {
         Value *V = *JU;
         if (I == V || Users.count(V)) {
           UsesI = true;