[llvm-commits] [cfe-commits] [PATCH][Review Request] EarlyCSE stack overflow - bugzilla 11794

[Jakob Stoklund Olesen]

On Jan 31, 2012, at 1:55 PM, Lenny Maiorani wrote:

> Please review this new patch. It uses the same method as the DepthFirstIterator to keep only the path back to the root node on the stack, pushes and pops scopes as appropriate by keeping pointers to them in the StackNode, and properly pushes and pops the CurrentGeneration.
> 
> I have tested this with my little C++ file generated by the Python script and the LLVM/Clang unit test suites. It all passes and the binaries output match.
> 
> This patch will be added to the bug #11794. Provided this passes review I will commit this patch. If not, I have run out of time to continue working on this and will have to move on.

Hi Lenny,

This new patch is looking good.

Just one thing: You don't need the 'processedNodes' set. The DomTree is a tree, so you will only encounter each node once. Just keep a 'Processed' bit in StackNode instead.

/jakob