[llvm-commits] [llvm] r149416 - /llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp

[Benjamin Kramer]

On 31.01.2012, at 21:34, Jim Grosbach wrote:

> Author: grosbach
> Date: Tue Jan 31 14:34:53 2012
> New Revision: 149416
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=149416&view=rev
> Log:
> Add explanatory comment.
> 
> Modified:
>    llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp
> 
> Modified: llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp?rev=149416&r1=149415&r2=149416&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp (original)
> +++ llvm/trunk/lib/Target/ARM/ARMConstantIslandPass.cpp Tue Jan 31 14:34:53 2012
> @@ -834,6 +834,7 @@
>     if (&*I == MI) return Offset;
>     Offset += TII->GetInstSizeInBytes(I);
>   }
> +  // Unreachable.
> }

Why not rewrite this loop as

  for (MachineBasicBlock::iterator I = MBB->begin(); &*I != MI; ++I) {
    assert(I != MBB->end() && "Didn't find MI in its own basic block?");
    Offset += TII->GetInstSizeInBytes(I);
  }
  return Offset;

and avoid the reachability confusion?

- Ben

> 
> /// CompareMBBNumbers - Little predicate function to sort the WaterList by MBB
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits