[llvm-commits] PATCH: Add 64-bit architecture predicate to llvm::Triple

[James Molloy]

Hi Chandler,

 

One point:

 

+  /// Note that this tests for 16-bit pointer width, and nothing else.

 

I’m not sure this comment is accurate. For example, real mode x86 would be 16-bit but has 24-bit pointers (seg:offset).

 

Perhaps you should just explain that it is the obvious native width of the register file or something (or  not be so explicit and let the reader rely on some common sense?)

 

Cheers,

 

James

 

From: Chandler Carruth [mailto:chandlerc at gmail.com] 
Sent: 30 January 2012 17:57
To: James Molloy; Anton Korobeynikov
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] PATCH: Add 64-bit architecture predicate to llvm::Triple

 

Updated patch, now with 64bit, 32bit, and 16bit. Also with unit tests to ensure this works, and continues to work. I've added a tiny blurb about why I used 3 predicates rather than exposing the bitwidth as an integer. I want these to be used as coarse categories, not precise architectural details.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120130/da7b2075/attachment.html>