[llvm-commits] [llvm] r149164 - /llvm/trunk/lib/CodeGen/DwarfEHPrepare.cpp

[Bill Wendling]

Author: void
Date: Fri Jan 27 19:17:56 2012
New Revision: 149164

URL: http://llvm.org/viewvc/llvm-project?rev=149164&view=rev
Log:
Reapply r149159 with a fix to add to a PHI node with a non-null parent.

Modified:
    llvm/trunk/lib/CodeGen/DwarfEHPrepare.cpp

Modified: llvm/trunk/lib/CodeGen/DwarfEHPrepare.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/DwarfEHPrepare.cpp?rev=149164&r1=149163&r2=149164&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/DwarfEHPrepare.cpp (original)
+++ llvm/trunk/lib/CodeGen/DwarfEHPrepare.cpp Fri Jan 27 19:17:56 2012
@@ -39,6 +39,7 @@
     Constant *RewindFunction;
 
     bool InsertUnwindResumeCalls(Function &Fn);
+    Instruction *GetExceptionObject(ResumeInst *RI);
 
   public:
     static char ID; // Pass identification, replacement for typeid.
@@ -64,6 +65,46 @@
   return new DwarfEHPrepare(tm);
 }
 
+/// GetExceptionObject - Return the exception object from the value passed into
+/// the 'resume' instruction (typically an aggregate). Clean up any dead
+/// instructions, including the 'resume' instruction.
+Instruction *DwarfEHPrepare::GetExceptionObject(ResumeInst *RI) {
+  Value *V = RI->getOperand(0);
+  Instruction *ExnObj = 0;
+  InsertValueInst *SelIVI = dyn_cast<InsertValueInst>(V);
+  LoadInst *SelLoad = 0;
+  InsertValueInst *ExcIVI = 0;
+  bool EraseIVIs = false;
+
+  if (SelIVI) {
+    if (SelIVI->getNumIndices() == 1 && *SelIVI->idx_begin() == 1) {
+      ExcIVI = dyn_cast<InsertValueInst>(SelIVI->getOperand(0));
+      if (ExcIVI && isa<UndefValue>(ExcIVI->getOperand(0)) &&
+          ExcIVI->getNumIndices() == 1 && *ExcIVI->idx_begin() == 0) {
+        ExnObj = cast<Instruction>(ExcIVI->getOperand(1));
+        SelLoad = dyn_cast<LoadInst>(SelIVI->getOperand(1));
+        EraseIVIs = true;
+      }
+    }
+  }
+
+  if (!ExnObj)
+    ExnObj = ExtractValueInst::Create(RI->getOperand(0), 0, "exn.obj", RI);
+
+  RI->eraseFromParent();
+
+  if (EraseIVIs) {
+    if (SelIVI->getNumUses() == 0)
+      SelIVI->eraseFromParent();
+    if (ExcIVI->getNumUses() == 0)
+      ExcIVI->eraseFromParent();
+    if (SelLoad && SelLoad->getNumUses() == 0)
+      SelLoad->eraseFromParent();
+  }
+
+  return ExnObj;
+}
+
 /// InsertUnwindResumeCalls - Convert the ResumeInsts that are still present
 /// into calls to the appropriate _Unwind_Resume function.
 bool DwarfEHPrepare::InsertUnwindResumeCalls(Function &Fn) {
@@ -91,8 +132,26 @@
 
   // Create the basic block where the _Unwind_Resume call will live.
   LLVMContext &Ctx = Fn.getContext();
+  unsigned ResumesSize = Resumes.size();
+
+  if (ResumesSize == 1) {
+    // Instead of creating a new BB and PHI node, just append the call to
+    // _Unwind_Resume to the end of the single resume block.
+    ResumeInst *RI = Resumes.front();
+    BasicBlock *UnwindBB = RI->getParent();
+    Instruction *ExnObj = GetExceptionObject(RI);
+
+    // Call the _Unwind_Resume function.
+    CallInst *CI = CallInst::Create(RewindFunction, ExnObj, "", UnwindBB);
+    CI->setCallingConv(TLI->getLibcallCallingConv(RTLIB::UNWIND_RESUME));
+
+    // We never expect _Unwind_Resume to return.
+    new UnreachableInst(Ctx, UnwindBB);
+    return true;
+  }
+
   BasicBlock *UnwindBB = BasicBlock::Create(Ctx, "unwind_resume", &Fn);
-  PHINode *PN = PHINode::Create(Type::getInt8PtrTy(Ctx), Resumes.size(),
+  PHINode *PN = PHINode::Create(Type::getInt8PtrTy(Ctx), ResumesSize,
                                 "exn.obj", UnwindBB);
 
   // Extract the exception object from the ResumeInst and add it to the PHI node
@@ -100,40 +159,11 @@
   for (SmallVectorImpl<ResumeInst*>::iterator
          I = Resumes.begin(), E = Resumes.end(); I != E; ++I) {
     ResumeInst *RI = *I;
-    BranchInst::Create(UnwindBB, RI->getParent());
+    BasicBlock *Parent = RI->getParent();
+    BranchInst::Create(UnwindBB, Parent);
 
-    Value *V = RI->getOperand(0);
-    Instruction *ExnObj = 0;
-    InsertValueInst *SelIVI = dyn_cast<InsertValueInst>(V);
-    LoadInst *SelLoad = 0;
-    InsertValueInst *ExcIVI = 0;
-    bool EraseIVIs = false;
-    if (SelIVI) {
-      if (SelIVI->getNumIndices() == 1 && *SelIVI->idx_begin() == 1) {
-        ExcIVI = dyn_cast<InsertValueInst>(SelIVI->getOperand(0));
-        if (ExcIVI && isa<UndefValue>(ExcIVI->getOperand(0)) &&
-            ExcIVI->getNumIndices() == 1 && *ExcIVI->idx_begin() == 0) {
-          ExnObj = cast<Instruction>(ExcIVI->getOperand(1));
-          SelLoad = dyn_cast<LoadInst>(SelIVI->getOperand(1));
-          EraseIVIs = true;
-        }
-      }
-    }
-
-    if (!ExnObj)
-      ExnObj = ExtractValueInst::Create(RI->getOperand(0), 0, "exn.obj", RI);
-
-    PN->addIncoming(ExnObj, RI->getParent());
-    RI->eraseFromParent();
-
-    if (EraseIVIs) {
-      if (SelIVI->getNumUses() == 0)
-        SelIVI->eraseFromParent();
-      if (ExcIVI->getNumUses() == 0)
-        ExcIVI->eraseFromParent();
-      if (SelLoad && SelLoad->getNumUses() == 0)
-        SelLoad->eraseFromParent();
-    }
+    Instruction *ExnObj = GetExceptionObject(RI);
+    PN->addIncoming(ExnObj, Parent);
 
     ++NumResumesLowered;
   }