[llvm-commits] [PATCH][AddressSanitizer] Make lib\asan compileable using Visual Studio

[Alexander Potapenko]

LGTM

On Fri, Jan 27, 2012 at 7:10 PM, Timur Iskhodzhanov <timurrrr at google.com> wrote:
> OK, removed it.
>
> Please take another look.
>
> Thanks,
> Timur
>
> On Fri, Jan 27, 2012 at 6:49 PM, Alexander Potapenko <glider at google.com> wrote:
>> +  unsigned long ret = -1;  // NOLINT
>> +  _BitScanForward64(&ret, x);
>> +  return ret;
>> +#elif defined(_WIN32)
>> +  unsigned long ret = -1;  // NOLINT
>>
>> Why do you need this initial value? This is not required from
>> __builtin_clz-like functions, and anyway checking for x to be nonzero
>> is better.



-- 
Alexander Potapenko
Software Engineer
Google Moscow