[llvm-commits] [PATCH][AddressSanitizer] Make lib\asan compileable using g++

Alexander Potapenko glider at google.com
Fri Jan 27 02:54:54 PST 2012


LGTM, I'll land this patch for you.

On Fri, Jan 27, 2012 at 2:51 PM, Timur Iskhodzhanov <timurrrr at google.com> wrote:
> Hi,
>
> The attached patch makes compiler-rt/trunk/lib/asan compileable with g++.
>
> The double-extern thing is
> http://llvm.org/bugs/show_bug.cgi?id=11869
>
> And the #include <string[s].h> are only needed on Mac (see comments in
> the original code)
> and also including them might make strchr/index conflict with the g++
> system headers (which don't follow the man pages, ouch!)
>
> Can you please do a review for this patch?
>
> Thanks,
> Timur Iskhodzhanov



-- 
Alexander Potapenko
Software Engineer
Google Moscow



More information about the llvm-commits mailing list