[llvm-commits] Intel Atom optimization - use LEA to adjust stack pointer

[Zhang, Andy]

Ping.

Has anyone had a chance to take a look at this?

Regards,
Andy

> -----Original Message-----
> From: llvm-commits-bounces at cs.uiuc.edu [mailto:llvm-commits-
> bounces at cs.uiuc.edu] On Behalf Of Zhang, Andy
> Sent: Wednesday, January 04, 2012 5:04 PM
> To: llvm-commits at cs.uiuc.edu
> Subject: Re: [llvm-commits] Intel Atom optimization - use LEA to adjust
> stack pointer
> 
> 
> On Friday, December 23, 2011 11:06 PM, Jakob Stoklund Olesen wrote:
> 
> > On Dec 23, 2011, at 10:23 AM, Zhang, Andy wrote:
> >
> > Hi Andy,
> >
> > Please submit the TableGen changes as an independent patch.
> >
> > From a quick glance, you also need to make sure you follow LLVM's
> > style for braces etc.
> >
> >      if (isSub)
> > +    {
> >        MI->setFlag(MachineInstr::FrameSetup);
> > -    MI->getOperand(3).setIsDead(); // The EFLAGS implicit def is
> dead.
> > +    }
> >
> > Why add braces here?
> >
> > /jakob
> I removed the braces from the single-statement if-statement blocks and
> updated the patch. Do you see any other issues?
> 
> Regards,
> Andy