[llvm-commits] Support of HURD

Sylvestre Ledru sylvestre at debian.org
Wed Jan 11 11:00:38 PST 2012


Le jeudi 12 janvier 2012 à 02:01 +0900, NAKAMURA Takumi a écrit :
> Sylvestre,
> 
> Thanks for working!
> 
> a few nit;
> 
>   - Doesn't the gnu have PATH_MAX nor MAXPATHLEN in his headers?
>     It should be detected on autoconf.
No, it does not ... (don't ask me why but it is the one of the most
common changes when doing the HURD porting).

About the autoconf detection, I can do it. To make sure we understand
each others, you would like something like:
* check if we are building on HURD
* if it is the case, defines PATH_MAX and MAXPATHLEN
* otherwise, do nothing

or something more general like:
* if we are building on a system which has not PATH_MAX and MAXPATHLEN
=> define it

>   - I guess (HAVE_MACH_H && !__GNU__) could be rewritten as
> (HAVE_MACH_H && Darwin).
>     How do you think?
Hmmm, probably! 
I will do this change.

Thanks for the review,
Sylvestre






More information about the llvm-commits mailing list