[llvm-commits] [PATCH] Segmented stack fixes, support for Mac, Win32, FreeBSD

[Brian Anderson]

In my previous message that updated these patches for stylistic issues I accidentally squashed the two mac commits into one, so there is one less patch. The result is still the same and the patches still reasonable so I'm not going to prise them apart again unless requested.

----- Original Message -----
> From: "Anton Korobeynikov" <anton at korobeynikov.info>
> To: "Brian Anderson" <banderson at mozilla.com>
> Cc: llvm-commits at cs.uiuc.edu, "Rafael Espindola" <respindola at mozilla.com>
> Sent: Saturday, January 7, 2012 9:40:10 AM
> Subject: Re: [llvm-commits] [PATCH] Segmented stack fixes, support for Mac, Win32, FreeBSD
> 
> Hello Brian
> 
> > For each platform I had to pick a slot in the TCB to store the
> > stack boundary. This is a difficult decision since that is
> > precious real estate. On Win32 I am using the pvArbitrary slot,
> > which is reserved for application use. On FreeBSD it uses
> > tcb_spare.
> win32 part looks ok for me.
> 
> However, please follow the LLVM's Code Style Convention, e.g.:
> 
> 1. Use "if (a ||
>                b)"
> 2. Do not put braces around single line statements in if / else, etc.
> 
> --
> With best regards, Anton Korobeynikov
> Faculty of Mathematics and Mechanics, Saint Petersburg State
> University
>