[llvm-commits] [patch] Remove MCLoggingStreamer

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Fri Jan 6 19:50:29 PST 2012


It looks to me that MCLoggingStreamer is costing more than it is worth.

It is a interesting debugging idea, but it doesn't add a lot more
information than the regular text asm printer. Specially in verbose asm
mode.

The value of the information being logged is also reduced when we split
a method to provide a non-virtual interface. After the split, we are
logging an implementation detail.

While the situation can be improved with cleaner separation of the
interface provided by MCStreamer and its implementation, it looks better
to just remove the logging streamer.

Is the attached patch ok?

Cheers,
Rafael
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: mclogging.patch
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120106/9aa061d3/attachment.ksh>


More information about the llvm-commits mailing list