[llvm-commits] [llvm] r147399 - in /llvm/trunk: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp test/CodeGen/X86/avx-shuffle-x86_32.ll Please review

[Demikhovsky, Elena]

Eli,
You are right about the mask. I fixed it.
Please look again.


- Elena

-----Original Message-----
From: Eli Friedman [mailto:eli.friedman at gmail.com] 
Sent: Monday, January 02, 2012 19:57
To: Demikhovsky, Elena
Cc: Rafael Ávila de Espíndola; llvm-commits at cs.uiuc.edu
Subject: Re: [llvm-commits] [llvm] r147399 - in /llvm/trunk: lib/CodeGen/SelectionDAG/LegalizeDAG.cpp test/CodeGen/X86/avx-shuffle-x86_32.ll Please review

2012/1/2 Demikhovsky, Elena <elena.demikhovsky at intel.com>:
> I fixed the patch and want to commit it.
> I re-checked all and CodeGen/ARM/vext.ll passes now.
>
> Please review.

What changed to fix this patch?

For the following:
+        // EltVT gets smaller
+        assert(factor > 0);
+        SmallVector<int, 32> NewMask(32U, -1);

Where does the "32U" come from in "NewMask(32U, -1)"?

For the following:
+        for (unsigned i = 0; i < VT.getVectorNumElements(); ++i) {
+          if (Mask[i] < 0) {
+            for (unsigned fi = 0; fi < factor; ++fi)
+              NewMask[i*factor+fi] = Mask[i];
+          }
+          else {
+            for (unsigned fi = 0; fi < factor; ++fi)
+              NewMask[i*factor+fi] = Mask[i]*factor+fi;
+          }
+          Mask = NewMask;
+        }

The assignment Mask = NewMask inside the loop looks very suspicious:
are you sure that's correct?

-Eli
---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: legalize_dag2.diff
Type: application/octet-stream
Size: 3805 bytes
Desc: legalize_dag2.diff
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20120103/a4d89be8/attachment.obj>