[llvm-commits] [llvm] r147404 - /llvm/trunk/lib/Target/X86/Disassembler/X86DisassemblerDecoder.c

Benjamin Kramer benny.kra at googlemail.com
Sun Jan 1 09:55:37 PST 2012


Author: d0k
Date: Sun Jan  1 11:55:36 2012
New Revision: 147404

URL: http://llvm.org/viewvc/llvm-project?rev=147404&view=rev
Log:
X86Disassembler: Fix undefined behavior found by GCC 4.6

Modified:
    llvm/trunk/lib/Target/X86/Disassembler/X86DisassemblerDecoder.c

Modified: llvm/trunk/lib/Target/X86/Disassembler/X86DisassemblerDecoder.c
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/Disassembler/X86DisassemblerDecoder.c?rev=147404&r1=147403&r2=147404&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/Disassembler/X86DisassemblerDecoder.c (original)
+++ llvm/trunk/lib/Target/X86/Disassembler/X86DisassemblerDecoder.c Sun Jan  1 11:55:36 2012
@@ -1502,9 +1502,11 @@
       return -1;
     case ENCODING_IB:
       if (sawRegImm) {
-        // saw a register immediate so don't read again and instead split the previous immediate
-        // FIXME: This is a hack
-        insn->immediates[insn->numImmediatesConsumed++] = insn->immediates[insn->numImmediatesConsumed - 1] & 0xf;
+        // Saw a register immediate so don't read again and instead split the
+        // previous immediate.  FIXME: This is a hack
+        insn->immediates[insn->numImmediatesConsumed] =
+          insn->immediates[insn->numImmediatesConsumed - 1] & 0xf;
+        ++insn->numImmediatesConsumed;
         break;
       }
       if (readImmediate(insn, 1))





More information about the llvm-commits mailing list