[llvm-commits] [llvm] r147036 - in /llvm/trunk: lib/Analysis/ValueTracking.cpp lib/Transforms/Utils/SimplifyCFG.cpp test/Transforms/SimplifyCFG/SpeculativeExec.ll

[Duncan Sands]

>>> Just checking mayHaveSideEffects() should cover almost everything here.
>>
>> Good point! Is there anything that mayHaveSideEffects() would return
>> true on that wouldn't be safe to speculate? The comment on
>> mayHaveSideEffects claims that a call to malloc would return false, but
>> that's a lie, suggesting that an audit of users of these two functions
>> is due...
>
> mayHaveSideEffects is essentially equivalent to mayWriteToMemory, and
> that is clearly not the same thing as being safe to speculate.

Maybe mayHaveSideEffects should then be eliminated, or changed to check
more side-effects?

Ciao, Duncan.