[llvm-commits] [PATCH][CMake] PR10050.

Chandler Carruth chandlerc at google.com
Sat Dec 24 01:34:50 PST 2011


High level questions:

Why generate tarballs as well as installing the actual docs?

Why set some of the binaries to 'true' and run those command
unconditionally, but in other cases just omit steps when the tools
necessary are unavailable? The latter sounds cleaner.

Does any of this happen for a normal build, or is it all only triggered by
an explicit target or 'make install'?

Please go ahead and commit the cpack version number fix, it's independent
of the rest.

I'll try to look through these more carefully, but they're a bit confusing.
Comments would likely help as the CMake languages doesn't make this kind of
stuff obvious.

On Sat, Dec 24, 2011 at 1:19 AM, arrowdodger <6yearold at gmail.com> wrote:

> I've uploaded patches to fix PR10050 (
> http://llvm.org/bugs/show_bug.cgi?id=10050 ) into bugzilla:
>
> http://llvm.org/bugs/attachment.cgi?id=7792
> http://llvm.org/bugs/attachment.cgi?id=7793
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111224/f8aad08c/attachment.html>


More information about the llvm-commits mailing list