[llvm-commits] [PATCH] Removes most of the templating from the JSON parser

[Manuel Klimek]

On Thu, Dec 22, 2011 at 7:25 PM, Chris Lattner <clattner at apple.com> wrote:
>
> On Dec 22, 2011, at 6:55 AM, Manuel Klimek wrote:
>
>> I'm happy to apply this if people feel like this improves the
>> situation. I'm not sure it does, though, which is why I'd like to get
>> comments on it first. Better? Worse? The same? Ideas how to make it
>> better?
>>
>> Rietveld: http://codereview.appspot.com/5504072
>
> I think that this is a lot better.  An improvement would be to keep some of the trivial methods (e.g. AtomIterator::AtomIterator) inline, which IMO makes things easier to read, and is probably better for performance.

It does not matter for the performance cases I benchmark at all
(they're pretty much parseString bound), but I'll happily inline the
trivial stuff (I outlined mainly because of your comment :).

Will check that in then. Thanks for your review!
/Manuel