[llvm-commits] [llvm] r146977 - /llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp

Rafael Ávila de Espíndola rafael.espindola at gmail.com
Thu Dec 22 05:41:11 PST 2011


> Why no tests needed? We should have tests that just exercise the
> parsing, no? If not, I think it would be good to wait on commit until
> enough functionality is there to at least have a sanity test.
> Essentially, you should have enough tests here to ensure you didn't
> commit an 'abort()' or a divide by zero.

Agreed. Jason, can you add a test showing that we at least parse
eabi_attribute and .arch?

Thanks,
Rafael



More information about the llvm-commits mailing list