[llvm-commits] [llvm] r146801 - in /llvm/trunk: include/llvm/MC/MCStreamer.h lib/CodeGen/AsmPrinter/AsmPrinterDwarf.cpp lib/MC/MCAsmStreamer.cpp lib/MC/MCLoggingStreamer.cpp lib/MC/MCNullStreamer.cpp lib/MC/MCParser/COFFAsmParser.cpp lib/MC/MCStr

[Rafael Ávila de Espíndola]

>     +
>     +#include "../Target/X86/MCTargetDesc/X86FixupKinds.h"
>     +
> 
> 
> This is a pretty egregious layering violation. Please fix or revert,
> this causes all kinds of problems with improper dependencies between
> various components.

This is not making library dependencies any worse:

grep -r X86FixupKinds.h lib/MC/
lib/MC/ELFObjectWriter.cpp:#include
"../Target/X86/MCTargetDesc/X86FixupKinds.h"
lib/MC/WinCOFFStreamer.cpp:#include
"../Target/X86/MCTargetDesc/X86FixupKinds.h"
lib/MC/WinCOFFObjectWriter.cpp:#include
"../Target/X86/MCTargetDesc/X86FixupKinds.h"

I will take a look at this this week, but reverting this will break
codegen of an empty main on windows with -g, so it seems like bit harsh
for what it is.

Cheers,
Rafael