[llvm-commits] PATCH: remove unused variable TheError

Chandler Carruth chandlerc at google.com
Tue Dec 20 15:16:35 PST 2011


On Tue, Dec 20, 2011 at 6:54 AM, Manuel Klimek <klimek at google.com> wrote:

> While searching for an example to model my use of SourceMgr after, I
> stumbled over LLLexer.h and found what looks like an unused variable -
> this patch would remove it, if there's not some hidden use of TheError
> that I'm missing.
>

Looks good. As long as this kind of change doesn't break the build in some
way, always feel free to commit as "obvious".


>
> diff --git a/lib/AsmParser/LLLexer.h b/lib/AsmParser/LLLexer.h
> index 33b9135..09aea5b 100644
> --- a/lib/AsmParser/LLLexer.h
> +++ b/lib/AsmParser/LLLexer.h
> @@ -42,7 +42,6 @@ namespace llvm {
>     APFloat APFloatVal;
>     APSInt  APSIntVal;
>
> -    std::string TheError;
>   public:
>     explicit LLLexer(MemoryBuffer *StartBuf, SourceMgr &SM, SMDiagnostic &,
>                      LLVMContext &C);
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111220/503fabca/attachment.html>


More information about the llvm-commits mailing list