[llvm-commits] some missing clang lib deps

[Eli Friedman]

On Wed, Dec 14, 2011 at 12:41 PM, David Fang <fang at csl.cornell.edu> wrote:
> Hi all,
>        I've checked out the latest llvm/clang svn trunk and built them for
> powerpc-darwin8 using g++-4.0.1 (OS X 10.4), cmake with
> BUILD_SHARED_LIBS=ON. The attached patch is all I needed to get this
> working.
>
> lib/AST/ExprConstant.cpp: g++-4.0 needed a template keyword as a
> diambiguator for template member functions in some contexts.  This is not
> needed with newer compilers, but should also be permitted.
>
> The rest of the patch adds missing dependencies between some clang libraries
> that were found during linking (undefined symbols otherwise.)
> Some of the CMakeLists.txt mentioned having to fix these as a TODO.
>
> Let me know if this patch or pieces of it are suitable for trunk.

The patch to lib/AST/ExprConstant.cpp breaks the 80-column rule, but
otherwise seems okay.

I don't know enough about the CMake build system to review those bits.

-Eli