[llvm-commits] [compiler-rt] r145966 - in /compiler-rt/trunk/lib/asan: asan_internal.h asan_rtl.cc

[Alexander Potapenko]

Oh, sorry, I see you've actually removed this flag.

On Wed, Dec 7, 2011 at 12:18 PM, Alexander Potapenko <glider at google.com> wrote:
> What's this flag for? Can you choose a better name?
>
> On Wed, Dec 7, 2011 at 1:10 AM, Kostya Serebryany <kcc at google.com> wrote:
>> Author: kcc
>> Date: Tue Dec  6 15:10:15 2011
>> New Revision: 145966
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=145966&view=rev
>> Log:
>> [asan] minor cleanup
>>
>> Modified:
>>    compiler-rt/trunk/lib/asan/asan_internal.h
>>    compiler-rt/trunk/lib/asan/asan_rtl.cc
>>
>> Modified: compiler-rt/trunk/lib/asan/asan_internal.h
>> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_internal.h?rev=145966&r1=145965&r2=145966&view=diff
>> ==============================================================================
>> --- compiler-rt/trunk/lib/asan/asan_internal.h (original)
>> +++ compiler-rt/trunk/lib/asan/asan_internal.h Tue Dec  6 15:10:15 2011
>> @@ -91,7 +91,6 @@
>>  extern int    FLAG_demangle;
>>  extern bool   FLAG_symbolize;
>>  extern int    FLAG_v;
>> -extern bool   FLAG_mt;
>>  extern size_t FLAG_redzone;
>>  extern int    FLAG_debug;
>>  extern bool   FLAG_poison_shadow;
>> @@ -177,7 +176,6 @@
>>
>>  // -------------------------- Atomic ---------------- {{{1
>>  static inline int AtomicInc(int *a) {
>> -  if (!FLAG_mt) return ++(*a);
>>  #ifdef ANDROID
>>   return __atomic_inc(a) + 1;
>>  #else
>> @@ -186,7 +184,6 @@
>>  }
>>
>>  static inline int AtomicDec(int *a) {
>> -  if (!FLAG_mt) return --(*a);
>>  #ifdef ANDROID
>>   return __atomic_dec(a) - 1;
>>  #else
>>
>> Modified: compiler-rt/trunk/lib/asan/asan_rtl.cc
>> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_rtl.cc?rev=145966&r1=145965&r2=145966&view=diff
>> ==============================================================================
>> --- compiler-rt/trunk/lib/asan/asan_rtl.cc (original)
>> +++ compiler-rt/trunk/lib/asan/asan_rtl.cc Tue Dec  6 15:10:15 2011
>> @@ -57,7 +57,6 @@
>>  bool   FLAG_fast_unwind = true;
>>
>>  size_t FLAG_redzone;  // power of two, >= 32
>> -bool   FLAG_mt;  // set to 0 if you have only one thread.
>>  size_t FLAG_quarantine_size;
>>  int    FLAG_demangle;
>>  bool   FLAG_symbolize;
>> @@ -665,7 +664,6 @@
>>   FLAG_debug = IntFlagValue(options, "debug=", 0);
>>   FLAG_replace_cfallocator = IntFlagValue(options, "replace_cfallocator=", 1);
>>   FLAG_fast_unwind = IntFlagValue(options, "fast_unwind=", 1);
>> -  FLAG_mt = IntFlagValue(options, "mt=", 1);
>>   FLAG_replace_str = IntFlagValue(options, "replace_str=", 1);
>>   FLAG_replace_intrin = IntFlagValue(options, "replace_intrin=", 0);
>>   FLAG_use_fake_stack = IntFlagValue(options, "use_fake_stack=", 1);
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
>
> --
> Alexander Potapenko
> Software Engineer
> Google Moscow



-- 
Alexander Potapenko
Software Engineer
Google Moscow