[llvm-commits] [llvm] r145916 - in /llvm/trunk/test/MC: ARM/relax-thumb2-branches.s MachO/relax-thumb2-branches.s

Jim Grosbach grosbach at apple.com
Mon Dec 5 23:51:03 PST 2011


On Dec 5, 2011, at 10:53 PM, NAKAMURA Takumi wrote:

> 2011/12/6 Jim Grosbach <grosbach at apple.com>:
>>> Would it be better if MC/MachO/ARM were there?
>> 
>> That's what I was suggesting, yes. Please do this.
> 
> Fixed in r145925, thanks!

Perfect! Thanks for doing that.

> 
>> Tests which generate MachO object files belong in the MachO directory, not the ARM directory. The MC/ARM tests aren't supposed to be testing object file format specific features, but rather target-independent parsing and encoding bits.
> 
> Shall we restore changes in r126401 and r133856?

Yes, that makes excellent sense now that we have a better place to put them. I'd forgotten about those patches, which I suppose explains why I was confused earlier!

Thanks again,

-Jim



More information about the llvm-commits mailing list