[llvm-commits] [PATCHES] fix JIT optimization level bug

nobled nobled at dreamwidth.org
Thu Dec 1 14:17:38 PST 2011

On Sun, Nov 27, 2011 at 1:07 PM, Duncan Sands <baldrick at free.fr> wrote:
> Hi nobled,
>> The first two patches fix two different bugs introduced with r144788:
>> first, the CodeGenOpt enum was being cast into
>> addPassesToEmitMachineCode()'s optional 'bool DisableVerify' argument
>> after the old optimization argument was removed in the api change
>> (would a warning on implicitly casting enum to bool be a good idea?);
>> and second, the TargetMachine wasn't being created with the
>> optimization level requested. The rest are just code cleanups after
>> that.
> please don't send 8 patches attached to one email, please send 8 emails.
> Or, better, two emails each with one patch since logically speaking there
> are two different patches: fix up optlevel, move target triples about.
> In short, one logical change per email/patch please.
Ah, sorry about that.
>> Okay to commit?
> They look OK, except why pass in the target triple as a string only to turn
> it into a triple object - why not pass in a triple object from the beginning?
You're right. Changed in the new (squashed together) refactor patch.

> Ciao, Duncan.
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ExecutionEngine-refactor-interface.patch
Type: text/x-patch
Size: 12920 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111201/35c7baf4/attachment.bin>

More information about the llvm-commits mailing list