[llvm-commits] Mips code review request

[reed kotler]

Hi Eric,

Due to emergency conditions, three of us are working at the same time to 
finish and drill the bug count to 0 on the MIPS direct object emitter 
and we are almost there.

There is overlap in the code between different bugs and for Jack to try 
and split this patch apart, it will likely create new bugs and certainly 
create a huge amount of work. I.e. two bugs often had their own 
individual issues as well as some common issues.

We have pic/no pic and delay slot/no delay slot optimization as well as 
our usual flavors.
There were lots of subtle issues and we have it right now.

We have about 10 build bots with all kinds of flavors being tested.

The MIPS object code emitter is all new work within the last month and half.

Reed


On 12/01/2011 12:57 PM, Eric Christopher wrote:
>
> On Dec 1, 2011, at 12:30 PM, Carter, Jack wrote:
>
>> I tried to break this up into smaller patches, but there was to much 
>> interdependency.
>>
>
> No patch attached. Also, given the descriptions, try harder.
>
> -eric
>
>> Unaligned load/stores: Clean up from earlier commit
>>     lib/Target/Mips/MipsMCInstLower.cpp
>>     lib/Target/Mips/MipsInstrInfo.td
>>     lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp
>>
>> Safe addend fixup:
>>     lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp
>>
>> Local/Global R_MIPS_GOT related fixups:
>>     include/llvm/Support/ELF.h
>>     include/llvm/MC/MCExpr.h
>>     lib/Target/Mips/MipsMCInstLower.cpp
>>     lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp
>>     lib/Target/Mips/MCTargetDesc/MipsFixupKinds.h
>>     lib/Target/Mips/MCTargetDesc/MipsBaseInfo.h
>>     lib/Target/Mips/MCTargetDesc/MipsAsmBackend.cpp
>>     lib/MC/ELFObjectWriter.cpp
>>
>> Explicit symbols for gnu mimicing relocations:
>>     lib/MC/ELFObjectWriter.cpp
>>     lib/MC/ELFObjectWriter.h
>>     lib/Target/Mips/InstPrinter/MipsInstPrinter.cpp
>>     lib/Target/Mips/MipsISelLowering.cpp
>>
>> Use branches instead of jumps
>>     lib/Target/Mips/MipsInstrFormats.td
>>     lib/Target/Mips/MipsInstrInfo.td
>>     lib/Target/Mips/MipsInstrInfo.cpp
>>     lib/Target/Mips/MipsRegisterInfo.cpp
>>     lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.cpp
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu <mailto:llvm-commits at cs.uiuc.edu>
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111201/486a3c63/attachment.html>