[llvm-commits] [llvm] r145413 - in /llvm/trunk: lib/Analysis/ValueTracking.cpp lib/Transforms/Utils/Local.cpp test/Transforms/InstCombine/align-external.ll

Duncan Sands baldrick at free.fr
Tue Nov 29 10:26:38 PST 2011

Author: baldrick
Date: Tue Nov 29 12:26:38 2011
New Revision: 145413

URL: http://llvm.org/viewvc/llvm-project?rev=145413&view=rev
Fix a theoretical problem (not seen in the wild): if different instances of a
weak variable are compiled by different compilers, such as GCC and LLVM, while
LLVM may increase the alignment to the preferred alignment there is no reason to
think that GCC will use anything more than the ABI alignment.  Since it is the
GCC version that might end up in the final program (as the linkage is weak), it
is wrong to increase the alignment of loads from the global up to the preferred
alignment as the alignment might only be the ABI alignment.

Increasing alignment up to the ABI alignment might be OK, but I'm not totally
convinced that it is.  It seems better to just leave the alignment of weak
globals alone.


Modified: llvm/trunk/lib/Analysis/ValueTracking.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ValueTracking.cpp?rev=145413&r1=145412&r2=145413&view=diff
--- llvm/trunk/lib/Analysis/ValueTracking.cpp (original)
+++ llvm/trunk/lib/Analysis/ValueTracking.cpp Tue Nov 29 12:26:38 2011
@@ -108,7 +108,7 @@
         // If the object is defined in the current Module, we'll be giving
         // it the preferred alignment. Otherwise, we have to assume that it
         // may only have the minimum ABI alignment.
-        if (!GVar->isDeclaration() && !GVar->mayBeOverridden())
+        if (!GVar->isDeclaration() && !GVar->isWeakForLinker())
           Align = TD->getPreferredAlignment(GVar);
           Align = TD->getABITypeAlignment(ObjectType);

Modified: llvm/trunk/lib/Transforms/Utils/Local.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/Local.cpp?rev=145413&r1=145412&r2=145413&view=diff
--- llvm/trunk/lib/Transforms/Utils/Local.cpp (original)
+++ llvm/trunk/lib/Transforms/Utils/Local.cpp Tue Nov 29 12:26:38 2011
@@ -748,6 +748,10 @@
     // If there is a large requested alignment and we can, bump up the alignment
     // of the global.
     if (GV->isDeclaration()) return Align;
+    // If the memory we set aside for the global may not be the memory used by
+    // the final program then it is impossible for us to reliably enforce the
+    // preferred alignment.
+    if (GV->isWeakForLinker()) return Align;
     if (GV->getAlignment() >= PrefAlign)
       return GV->getAlignment();

Modified: llvm/trunk/test/Transforms/InstCombine/align-external.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/InstCombine/align-external.ll?rev=145413&r1=145412&r2=145413&view=diff
--- llvm/trunk/test/Transforms/InstCombine/align-external.ll (original)
+++ llvm/trunk/test/Transforms/InstCombine/align-external.ll Tue Nov 29 12:26:38 2011
@@ -1,7 +1,7 @@
 ; RUN: opt < %s -instcombine -S | FileCheck %s
-; Don't assume that external global variables have their preferred
-; alignment. They may only have the ABI minimum alignment.
+; Don't assume that external global variables or those with weak linkage have
+; their preferred alignment. They may only have the ABI minimum alignment.
 ; CHECK: %s = shl i64 %a, 3
 ; CHECK: %r = or i64 %s, ptrtoint (i32* @A to i64)
@@ -11,7 +11,7 @@
 target datalayout = "-i32:8:32"
 @A = external global i32
- at B = external global i32
+ at B = weak_odr global i32 0
 define i64 @foo(i64 %a) {
   %t = ptrtoint i32* @A to i64
@@ -20,3 +20,10 @@
   %q = add i64 %r, 1
   ret i64 %q
+define i32 @bar() {
+; CHECK: @bar
+  %r = load i32* @B, align 1
+; CHECK: align 1
+  ret i32 %r

More information about the llvm-commits mailing list