[llvm-commits] [patch] MIPS processors renaming

Hatanaka, Akira ahatanaka at mips.com
Tue Nov 29 08:29:52 PST 2011

I can commit this if there are no objections.

We will also need to replace "4ke" with "mips32r2" wherever it is used (Makefiles, python driver, etc.).

From: Atanasyan, Simon
Sent: Tuesday, November 29, 2011 6:57 AM
To: llvm-commits at cs.uiuc.edu
Cc: Hatanaka, Akira; bruno.cardoso at gmail.com
Subject: [llvm-commits] [patch] MIPS processors renaming

Current MIPS "generic" processors names (mips32r1, 4ke, mips64r1, mips64r2) defined in the Mips.td cause some problems:
1. The list includes ISA names (mips32r1, mips64r1, mips64r2) and a processor family name (4ke). I think it looks inconsistently.
2. The processor family name (4ke) and ISA names (mips32r1, mips64r1) matches to neither processors names nor ISA names accepted by GNU binutlis. GNU tools use the following ISA names: mips32, mips32r2, mips64, mips64r2.
3. The MipsTargetInfoBase::getDefaultFeatures() routine uses a processor name to find corresponding feature set and turns it on. Mips processors names do not match to the corresponding feature set names (mips32, mips32r2, mips64, mips64r2) defined in the Mips.td. Therefore, the getDefaultFeatures() cannot find a feature set. This leads to the "'+<cpu name>' is not a recognized feature for this target" warning during compilation.

Here is the patch does the following renaming to solve the problems above:
1. mips32r1 to mips32
2. 4ke to mips32r2
3. mips64r1 to mips64

If this patch is accepted, I will send a complementary patch for clang to the cfe-commits list.


More information about the llvm-commits mailing list