[llvm-commits] [PATCH] PR889: devirtualize Value::printCustom

[Jay Foad]

On 14 November 2011 18:38, Chris Lattner <clattner at apple.com> wrote:
> The "right" way to fix this is to eliminate PseudoSourceValue, which has always been a disgusting hack.  Places in codegen that can uses PseudoSourceValue (e.g. the SDLoadNode and memoperands)

LoadSDNode has-a MachineMemOperand, which has-a MachinePointerInfo,
which is the (only?) thing that can refer to PseudoSourceValues.

> should use a discriminated union of "Value* and SomeMachineLocationType".

I assume you're not talking about (MC's) MachineLocation here, but
about some new machine location type yet to be invented.

Jay.