[llvm-commits] [llvm] r144621 - /llvm/trunk/include/llvm/Support/Compiler.h

[Nick Lewycky]

NAKAMURA Takumi wrote:
> Author: chapuni
> Date: Mon Nov 14 23:24:26 2011
> New Revision: 144621
>
> URL: http://llvm.org/viewvc/llvm-project?rev=144621&view=rev
> Log:
> include/llvm/Support/Compiler.h: Invalidate LLVM_ATTRIBUTE_WEAK on cygming for now.
>
> It triggers generating insane executables with both binutils-2.19.1(msysgit) and 2.22.51.20111013(cygwin).

Thanks for diagnosing this for me!!

Nick

>
> Modified:
>      llvm/trunk/include/llvm/Support/Compiler.h
>
> Modified: llvm/trunk/include/llvm/Support/Compiler.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/Compiler.h?rev=144621&r1=144620&r2=144621&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/Support/Compiler.h (original)
> +++ llvm/trunk/include/llvm/Support/Compiler.h Mon Nov 14 23:24:26 2011
> @@ -61,7 +61,7 @@
>   #define LLVM_ATTRIBUTE_READONLY
>   #endif
>
> -#if (__GNUC__>= 4)
> +#if (__GNUC__>= 4)&&  !defined(__MINGW32__)&&  !defined(__CYGWIN__)
>   #define LLVM_ATTRIBUTE_WEAK __attribute__((__weak__))
>   #else
>   #define LLVM_ATTRIBUTE_WEAK
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>