[llvm-commits] [llvm] r144122 - /llvm/trunk/lib/Target/ARM/ARMFastISel.cpp

[Eric Christopher]

On Nov 8, 2011, at 1:52 PM, Chad Rosier wrote:

> 
> On Nov 8, 2011, at 1:26 PM, Eric Christopher wrote:
> 
>> 
>> On Nov 8, 2011, at 1:12 PM, Chad Rosier wrote:
>> 
>>> ARMFastISel doesn't support thumb1.  Rename isThumb to isThumb2 to reflect this.
>>> No functional change intended.
>> 
>> 
>> That's what this code is there for:
>> 
>>     // Darwin and thumb1 only for now.
> 
> Shouldn't this read: // Darwin and non-thumb1 for now?
> 

Uh. Yep :)

>>     const ARMSubtarget *Subtarget = &TM.getSubtarget<ARMSubtarget>();
>>     if (Subtarget->isTargetDarwin() && !Subtarget->isThumb1Only() &&
>>         !DisableARMFastISel)
>> 
>> I guess for most of those a thumb2 check is probably better anyhow though, since we use mostly t2 instructions.
> 
> That was exactly my reasoning.  Most, if not all, thumb instructions are encoded as thumb2, so I prefer this naming.  I doubt we'll be adding support for thumb1 unless there's a performance advantage.

It's icky :) There are additional contortions for thumb1 on some instructions :)

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20111108/68299653/attachment.html>