[llvm-commits] patch: partial DSE

[Devang Patel]

On Oct 31, 2011, at 5:38 PM, Peter Cooper wrote:

> Hi
> 
> Please review this patch to allow DSE to trim stores as opposed to deleting them.
> 
> The logic here is that if the end of the earlier store is dead because of a later store then the length of the earlier store will be trimmed in size to avoid writing dead memory.  The only time i won't do this is if the original store was likely to use vector writes which if shortened would end up as multiple scalar writes and so is less efficient.

+        if (OR == OverwriteComplete) {
+          DEBUG(dbgs() << "DSE: Remove Dead Store:\n  DEAD: "
+                << *DepWrite << "\n  KILLER: " << *Inst << '\n');
+        
+          if (OR == OverwriteComplete) {

You're checking the same thing twice here.
-
Devang